Add explicit listener lifecycle management #52

jonasew · 2026-04-03T10:07:29Z

Problem: Network listeners are started but not clearly stopped, which can lead to duplicated callbacks or stale subscriptions (not tested yet, so is not confirmed yet). Basically, when the player goes from one screen to the next, the network listener from the previous game is still active

Target files:

GameNetworkHandler.java
GameScreen.java:439
AndroidFirebase.java

Refactor:

Add stop/dispose methods in the networking layer.
Store references to every ValueEventListener/ChildEventListener in AndroidFirebase and unregister them when screen exits.
Call networkHandler.stop() from both hide and dispose.

Acceptance criteria:

Re-entering a match screen does not duplicate opponent move events.
No listener callbacks arrive after leaving the match.

#52, #53) - Track all Firebase listeners via cleanup runnables in AndroidFirebase - Add removeAllListeners() to FirebaseAPI interface - Add stop() to GameNetworkHandler, called from GameScreen hide/dispose - Fix confirmSetup: propagate errors to onError callback instead of silently calling onSuccess on failure paths - Update SetupFlowController to pass error callback to confirmSetup

francinv self-assigned this Apr 4, 2026

francinv mentioned this issue Apr 6, 2026

fix: add listener lifecycle management and confirmSetup error handling #59

Merged

Add explicit listener lifecycle management #52

Add explicit listener lifecycle management #52

Comments

jonasew commented Apr 3, 2026