Fix setup confirm error semantics (Firebase error handling) #53

jonasew · 2026-04-03T10:13:51Z

Problem: confirmSetup currently reports success even on some failure paths.

Target file:

AndroidFirebase.java:144

Refactor:

Change API contract to include onError callback for confirmSetup.
Propagate failures to setup flow instead of silently continuing.

Acceptance criteria:

Firebase write failure gives explicit UI error and does not proceed as confirmed.

#52, #53) - Track all Firebase listeners via cleanup runnables in AndroidFirebase - Add removeAllListeners() to FirebaseAPI interface - Add stop() to GameNetworkHandler, called from GameScreen hide/dispose - Fix confirmSetup: propagate errors to onError callback instead of silently calling onSuccess on failure paths - Update SetupFlowController to pass error callback to confirmSetup

francinv self-assigned this Apr 4, 2026

francinv mentioned this issue Apr 6, 2026

fix: add listener lifecycle management and confirmSetup error handling #59

Merged

Fix setup confirm error semantics (Firebase error handling) #53

Fix setup confirm error semantics (Firebase error handling) #53

Comments

jonasew commented Apr 3, 2026