Skip to content

Commit

Permalink
Fix: Renamed method in Portfolio
Browse files Browse the repository at this point in the history
  • Loading branch information
tommyah committed May 25, 2026
1 parent 9310cae commit d6d29ed
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ public BigDecimal getNetWorth() {
* @return BigDecimal representing total quantity of all
* shares of this symbol.
* */
public BigDecimal getTotalSharesBySymbol(final String symbol) {
public BigDecimal getTotalShareQuantityBySymbol(final String symbol) {
if (symbol == null) {
return BigDecimal.ZERO;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ private void populateStockList(final String filter) {

getViewElement().setOnStockAction(stockBtn, s, (Stock stock) -> {
BigDecimal amountOfSharesOwned = player.getPortfolio()
.getTotalSharesBySymbol(s.getSymbol());
.getTotalShareQuantityBySymbol(s.getSymbol());
handleStockSelection(stock, amountOfSharesOwned.floatValue());
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,21 +131,21 @@ void containsThrowsExceptionOnIllegalArgument() {
void getTotalSharesBySymbolReturnsCorrectValues() {
assertEquals(0,
BigDecimal.ZERO.compareTo(
testPortfolio.getTotalSharesBySymbol("AAPL")
testPortfolio.getTotalShareQuantityBySymbol("AAPL")
)
);

assertEquals(0,
BigDecimal.ZERO.compareTo(
testPortfolio.getTotalSharesBySymbol(null)
testPortfolio.getTotalShareQuantityBySymbol(null)
)
);

testPortfolio.addShare(testShare);

assertEquals(0,
new BigDecimal("2.0").compareTo(
testPortfolio.getTotalSharesBySymbol("AAPL")
testPortfolio.getTotalShareQuantityBySymbol("AAPL")
)
);
}
Expand Down

0 comments on commit d6d29ed

Please sign in to comment.