Skip to content

Refactoring to reduce coupling #113

Closed
1 of 11 tasks
tommyah opened this issue May 23, 2026 · 0 comments · Fixed by #128
Closed
1 of 11 tasks

Refactoring to reduce coupling #113

tommyah opened this issue May 23, 2026 · 0 comments · Fixed by #128
Assignees
Labels
bug Something isn't working

Comments

@tommyah
Copy link
Member

tommyah commented May 23, 2026

As of now the system has various degrees of coupling. Controllers access the model by using an internal reference, which is injected from the main class. This should be replaced with a more generic and flexible system, such as the pub/sub system already in place.

Additions to consider:

  • More use of pub/sub, less direct dependency injection
  • Universal search widget used multiple places
  • Refresh logic for various controllers (refresh in superclass?)
  • Method for wiring buttons to actions in view element superclass
  • Tweak "TopBarController.setMarketIntegration()" to act more universal
  • Show playerstatus in top bar
  • Change color of top bar
  • Change graph, buttons and text in financial summary
  • Refactor unit testing, write new unit tests for various classes
  • Make sure every class has appropriate JavaDoc
  • Package-info.java files in every package
@tommyah tommyah self-assigned this May 23, 2026
@tommyah tommyah added the bug Something isn't working label May 23, 2026
@tommyah tommyah linked a pull request May 25, 2026 that will close this issue
Sign in to join this conversation on GitHub.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant