From f94ea8f0b0217e0d6194ce991d25fd36aab4b083 Mon Sep 17 00:00:00 2001 From: pawelsa Date: Sat, 16 May 2026 17:06:16 +0200 Subject: [PATCH] fix(Portfolio): CalculateTotal -> CalculateGross while checking profits. --- .../java/edu/ntnu/idi/idatt/model/portfolio/Portfolio.java | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/main/java/edu/ntnu/idi/idatt/model/portfolio/Portfolio.java b/src/main/java/edu/ntnu/idi/idatt/model/portfolio/Portfolio.java index 78a591b..4018da2 100644 --- a/src/main/java/edu/ntnu/idi/idatt/model/portfolio/Portfolio.java +++ b/src/main/java/edu/ntnu/idi/idatt/model/portfolio/Portfolio.java @@ -74,12 +74,7 @@ public BigDecimal getOwnedAmount(String symbol) { } public BigDecimal getProfitFromStock(String symbol) { - return getShares(symbol).stream().map(s -> { - BigDecimal total = new SaleCalculator(s).calculateTotal(); - BigDecimal buyPrice = s.getQuantity().multiply(s.getPurchasePrice()); - - return total.subtract(buyPrice); - }).reduce(BigDecimal.ZERO, BigDecimal::add); + return getShares(symbol).stream().map(s -> s.getProfit()).reduce(BigDecimal.ZERO, BigDecimal::add); } public BigDecimal getChangeFromStock(String symbol) {