misc: inspection fixes (#80)

* Update properties in FileStorageService and Medal classes to mutable

* Remove unused methods and properties from repositories and enums

src/main/kotlin/edu/ntnu/idi/idatt/backend/game/gameProgress/infrastructure/PupilGameProgressRepository.kt

@@ -19,14 +19,4 @@ interface PupilGameProgressRepository : JpaRepository<PupilGameProgress, PupilGa
         pupilUserId: Long,
         classroomId: Long,
     ): PupilGameProgress?
-
-    /**
-     * Finds all progress records for a classroom.
-     *
-     * @param classroomId the classroom ID
-     * @return all progress records registered for the classroom, ordered for leaderboard display
-     */
-    fun findAllByClassroomIdOrderByTotalScoreDescTotalXpDescCurrentLevelDescLastActivityAtDesc(
-        classroomId: Long,
-    ): List<PupilGameProgress>
 }

src/main/kotlin/edu/ntnu/idi/idatt/backend/game/tasks/domain/TaskType.kt

@@ -4,12 +4,10 @@ package edu.ntnu.idi.idatt.backend.game.tasks.domain
  * Coarse content categories for authored tasks.
  */
 enum class TaskType {
-    EMAIL_REVIEW,
     NEWS_COMPARISON,
     IMAGE_ASSESSMENT,
     IMAGE_SELECT,
     PASSWORD_EVALUATION,
     SOCIAL_SCENARIO,
-    FINAL_BOSS,
     GENERIC,
 }

src/main/kotlin/edu/ntnu/idi/idatt/backend/iam/domain/UserStatus.kt

@@ -6,5 +6,4 @@ package edu.ntnu.idi.idatt.backend.iam.domain
 enum class UserStatus {
     ACTIVE,
     INACTIVE,
-    SUSPENDED,
 }

src/main/kotlin/edu/ntnu/idi/idatt/backend/medals/domain/Medal.kt

@@ -29,19 +29,19 @@ import jakarta.persistence.Table
 class Medal(
     @Id
     @GeneratedValue(strategy = GenerationType.IDENTITY)
-    val id: Long = 0,
+    var id: Long = 0,
     @Column(nullable = false, unique = true)
-    val code: String,
+    var code: String,
     @Column(nullable = false)
-    val title: String,
+    var title: String,
     @Column
-    val description: String?,
+    var description: String?,
     @Enumerated(EnumType.STRING)
     @Column(nullable = false)
-    val medalType: MedalType,
+    var medalType: MedalType,
     @ManyToOne(fetch = FetchType.LAZY)
     @JoinColumn(name = "stop_id")
-    val stop: MapStop?,
+    var stop: MapStop?,
     @Column
-    val iconUrl: String?,
+    var iconUrl: String?,
 )

src/main/kotlin/edu/ntnu/idi/idatt/backend/mystery/infrastructure/WeeklyMysteryRepository.kt

@@ -16,13 +16,6 @@ interface WeeklyMysteryRepository : JpaRepository<WeeklyMystery, Long> {
     /** Full history ordered newest-first. Used by the teacher management view. */
     fun findAllByClassroomIdOrderByWeekStartDesc(classroomId: Long): List<WeeklyMystery>
 
-    /** Whether a given submission is already featured in a specific week. Used for UI hints. */
-    fun existsByClassroomIdAndSubmissionIdAndWeekStart(
-        classroomId: Long,
-        submissionId: Long,
-        weekStart: LocalDate,
-    ): Boolean
-
     /** Removes a specific featured entry so a teacher can un-feature a submission from a week. */
     fun deleteByIdAndClassroomId(
         id: Long,

src/main/kotlin/edu/ntnu/idi/idatt/backend/upload/application/FileStorageService.kt

@@ -22,7 +22,7 @@ import java.util.UUID
  */
 @Service
 class FileStorageService(
-    @Value("\${app.uploads.base-url}") private val baseUrl: String,
+    @Value($$"${app.uploads.base-url}") private val baseUrl: String,
     @Value($$"${app.uploads.base-dir:${user.home}/nettdetektivene/uploads}") private val baseDirPath: String,
 ) {
     private val baseStorageDir by lazy { Paths.get(baseDirPath).toAbsolutePath() }

src/main/kotlin/edu/ntnu/idi/idatt/backend/xp/infrastructure/PupilXpEventRepository.kt

@@ -18,18 +18,6 @@ interface PupilXpEventRepository : JpaRepository<PupilXpEvent, PupilXpEventId> {
      */
     fun findAllByIdPupilUserId(pupilUserId: Long): List<PupilXpEvent>
 
-    /**
-     * Checks whether one XP event has already been awarded to one pupil.
-     *
-     * @param pupilUserId identifier of the pupil.
-     * @param xpEventId identifier of the XP event definition.
-     * @return `true` when the composite award row already exists.
-     */
-    fun existsByIdPupilUserIdAndIdXpEventId(
-        pupilUserId: Long,
-        xpEventId: Long,
-    ): Boolean
-
     /**
      * Finds the awarded XP row for one pupil-event pair.
      *