update[LoginController]: improve password handling by clearing passwa…

…rd char array, and by not saving a password String as a variable

src/main/java/edu/group5/app/control/LoginController.java

@@ -5,6 +5,9 @@
 import edu.group5.app.model.user.UserService;
 import edu.group5.app.view.loginpage.LoginPageView;
 import edu.group5.app.view.loginpage.SignInPageView;
+
+import java.util.Arrays;
+
 import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder;
 
 public class LoginController {
@@ -27,9 +30,13 @@ public void handleSignIn(SignInPageView view, String firstName, String lastName,
       return;
     }
 
-    String password = new String(passwordChars);
     BCryptPasswordEncoder encoder = new BCryptPasswordEncoder();
-    String hashedPassword = encoder.encode(password);
+
+    // Clears password char array after creating a hash.
+    String hashedPassword = encoder.encode(new String(passwordChars));
+    for (int i = 0; i < passwordChars.length; i++) {
+      passwordChars[0] = '0';
+    }
 
     boolean success = userService.registerUser(
         "Customer", firstName, lastName, email, hashedPassword);