Skip to content

Conversation

tobiaheg
Copy link
Member

Summary

Updates the existing reviews query to fetch only reviews for the selected game, instead of fetching all reviews and filtering them in the frontend.

  • Requires gameId and filters reviews directly in the database.
  • Returns reviews sorted newest first.
  • Includes author names through a database join, removing the need to fetch all users.
  • Removes frontend filtering, sorting, and user lookup.
  • Fixes an existing unused prop binding in Top5Games that blocked the production build.

Validation

  • Backend tests pass, including five review-related tests.
  • All 19 frontend tests pass.
  • Frontend production build passes.
  • Database integration tests were not run because Docker access was unavailable.

No database migration is required.

Closes #84

@tobiaheg tobiaheg added the bug Something isn't working label Nov 10, 2026
@tobiaheg tobiaheg added this to the Delivery four milestone Nov 10, 2026
@tobiaheg tobiaheg requested a review from kfmelen November 10, 2026 12:10
@tobiaheg tobiaheg self-assigned this Nov 10, 2026
@tobiaheg tobiaheg requested a review from a team as a code owner November 10, 2026 12:10
@tobiaheg tobiaheg linked an issue Nov 10, 2026 that may be closed by this pull request
Copy link
Member

@kfmelen kfmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tobiaheg tobiaheg merged commit 2a71eb0 into main Nov 10, 2026
@tobiaheg tobiaheg deleted the 84-fetch-only-relevant-reviews-from-the-backend branch November 10, 2026 12:21
Sign in to join this conversation on GitHub.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch only relevant reviews from the backend
2 participants