feat: add map page mockup #39
Merged
+1,738
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a stylized SVG map of Trondheim that can be panned and zoomed, with a pin for each place. Add a left-hand panel with search and a fixed-size detail view with a back arrow. Add hash-based routing, make Utforsk in the main navigation open the map, and add coordinates to Place.
alekskjo
requested changes
Oct 9, 2026
There was a problem hiding this comment.
Kartet ser bra ut og fungerer fint både på desktop og mobil.
Det er én konkret feil som må rettes: Søkefeltet filtrerer resultatlisten, men alle kartmarkørene blir fortsatt vist. MapPanel bruker de filtrerte resultatene, mens MapViewport får hele listen med steder. Kartet bør bruke samme filtrerte resultat som listen.
Denne PR-en bygger også på frontend-commitene i #40. Merge derfor #40 først, oppdater deretter denne branchen mot fersk main, og kontroller at diffen bare inneholder kartendringene.
Når søk og kart viser de samme resultatene og branchen er oppdatert, kan PR-en godkjennes.
alekskjo
previously approved these changes
Oct 9, 2026
ktnielse
dismissed
alekskjo’s stale review
The merge-base changed after approval.
ktnielse
dismissed
alekskjo’s stale review
The merge-base changed after approval.
alekskjo
previously approved these changes
Oct 9, 2026
alekskjo
approved these changes
Oct 9, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a map page mockup that works without a backend or external map API. It uses the same mock data as the main page, so it can be connected to the GraphQL API later.
Changes
latitudeandlongitudeadded toPlaceRelated issues
Related to #13