Skip to content

Conversation

ktnielse
Copy link
Member

@ktnielse ktnielse commented Oct 13, 2026 •

Summary

Adds the routes page (#/ruter), reusing the map and side panel from the explore page.

  • My routes: lists saved routes. Opening one shows it on the map and lists its stops in the panel. Selecting a stop shows the place details, and the back arrow returns to the route.
  • Create route: add stops by searching or clicking a pin, then save the route with a name (max 30 characters). It appears under "My routes".

Notes

  • Routes are stored in localStorage behind api/routes.ts, to be replaced by GraphQL calls later.
  • MapViewport got optional props for the route line, numbered pins and fit-to-places.
  • Extracted usePanelInset and matchesQuery so both map pages share them.
  • Added tests for the routes api and page.

Issues

Related to #17 and #18.

@ktnielse ktnielse requested a review from a team as a code owner October 13, 2026 09:58
@andss andss self-assigned this Oct 13, 2026
Copy link
Member

@andss andss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the routes page, route builder, local storage API, shared map changes and tests.

The implementation reuses the existing map and place-detail components well. Route creation supports adding and removing stops, requires at least two stops before saving, and limits the route name to 30 characters. Saved routes preserve the stop order and can be reopened to view the route and individual place details.

The draft-stop interaction is now fixed: clicking a stop opens its details, and “Back to draft” returns to the existing draft. The new regression test covers this flow. The tests also cover saving routes, persistence after reload and invalid stored data.

Using localStorage is clearly documented as a temporary solution until GraphQL integration is ready.

All 16 tests, the production build, formatting and lint checks pass. No blocking issues found. Approved.

@andss andss merged commit 407c59e into main Oct 13, 2026
1 check passed
@andss andss deleted the feat/routes-page branch October 13, 2026 12:50
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants