Skip to content

Conversation

kristnu
Copy link
Member

@kristnu kristnu commented Sep 17, 2026

favorites are pinned after refresh

må nok bruke state bs for å fikse automatisk pinning

@kristnu kristnu requested a review from a team as a code owner September 17, 2026 23:47
Copy link
Member

@henrygr henrygr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, you cannot unstar places now, neither from the list or from search unless you have not changed location after starring the place

Copy link
Member

@henrygr henrygr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicked the wrong thing, meant to request changes

@henrygr
Copy link
Member

henrygr commented Sep 18, 2026

Also, fix the formatting, but that should be obvious

@henrygr
Copy link
Member

henrygr commented Sep 18, 2026

And the tests need to be updated to match the new contract, as you changed some component properties

I reccomend running "npm run pre-commit" before commiting as it runs the linter, formatter and tests so you can avoid unnecessary extra commits to fix these issues

@kristnu kristnu requested a review from henrygr September 18, 2026 16:25
Copy link
Member

@henrygr henrygr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🔥

@kristnu kristnu merged commit 05366bc into main Sep 18, 2026
1 check passed
@kristnu kristnu deleted the feat/pin-favorites branch September 18, 2026 16:41
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants