Skip to content

Conversation

carmennt
Copy link
Member

@carmennt carmennt commented Nov 10, 2026 •

This PR adds:

  • E2E tests with playwright (npx playwright install) and monarch for coverage reports (npm install monocart-coverage-reports)
  • A set of api tests

Closes: #88

elinejaa and others added 30 commits November 6, 2026 12:07
elidaks

This comment was marked as duplicate.

@carmennt carmennt dismissed elidaks’s stale review November 13, 2026 10:50

The merge-base changed after approval.

elidaks

This comment was marked as duplicate.

@elinejaa elinejaa marked this pull request as draft November 13, 2026 10:55
@carmennt carmennt dismissed elidaks’s stale review November 13, 2026 10:55

The merge-base changed after approval.

@elinejaa elinejaa marked this pull request as ready for review November 13, 2026 10:55
elidaks

This comment was marked as duplicate.

@carmennt carmennt requested a review from elinejaa November 13, 2026 10:56
Copy link
Member

@elinejaa elinejaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@carmennt carmennt assigned carmennt and unassigned carmennt Nov 13, 2026
elinejaa

This comment was marked as duplicate.

@catrinjo catrinjo self-requested a review November 13, 2026 10:58
catrinjo

This comment was marked as duplicate.

@elinejaa elinejaa assigned elinejaa and unassigned carmennt Nov 13, 2026
elinejaa

This comment was marked as duplicate.

carmennt

This comment was marked as off-topic.

elinejaa

This comment was marked as duplicate.

Copy link
Member

@catrinjo catrinjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fantastic!

@carmennt carmennt dismissed stale reviews from elinejaa, catrinjo, and elidaks November 13, 2026 11:00

The merge-base changed after approval.

Copy link
Member

@catrinjo catrinjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@carmennt carmennt requested a review from a team November 13, 2026 11:01
Copy link
Member

@elinejaa elinejaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@carmennt carmennt requested a review from a team November 13, 2026 11:02
@carmennt carmennt closed this Nov 13, 2026
@catrinjo catrinjo deleted the end-to-end-and-api-testing branch November 13, 2026 13:05
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End-to-end testing and api tests
4 participants