-
Notifications
You must be signed in to change notification settings - Fork 0
Update search functionality #46
Merged
Merged
+1,969
−199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not done yet, but the sorting and filter buttons are in place.
3 tasks
Now you can reclick a sotring option to remove it. And Filtering will allow you to click multiple and reclick for removing filters
Changing the color of the selected page in navbar to be primary accent color
Not done yet, but the sorting and filter buttons are in place.
Now you can reclick a sotring option to remove it. And Filtering will allow you to click multiple and reclick for removing filters
Changing the color of the selected page in navbar to be primary accent color
…IT2810-H26/T10-Project-2 into 40-update-search-functionality
Lost the pagination functions in resbase, added them from main
Sorting is looking like it is working as it should. Small bug, when sorting by title games with number come before letters.
Searching now works as inteended, and sorting works with it.
Update gamepage
Making a fetchGenres function that will split the genres from the DB to a unique list of strings.
Now the search query, filters and sorting option a user has will be saved in session storage so that it stays on page refresh.
Adding silient error through console.log when failing to save info at searchpage to session storage.
elinejaa
commented
Oct 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your part looks really good!
elidaks
approved these changes
Oct 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Looks awesome!
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searchpage will now be functional with:
All of these should be saved in sessionstorage to give more users a more fluid user interaction on the page.
closes issue: #40