Update main page display sections #53
Merged
+956
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 14, 2026 10:32
add optional rank badge parameter to passivegamecard, allowing for numbered rank visualization for games when enabled
update mainpage by adding more sections and visuals, showing a Top 3 Games section, and sections based on genre selection that display top 10 games or discounted games of that genre. Additionally included a hard-coded recent reviews section.
8 tasks
…nto 39-update-main-page-display-sections
elinejaa
requested changes
Oct 16, 2026
There was a problem hiding this comment.
Generally looks really good, great layout! Just a few changes I would like to see:
- Fade on passive game title should only appear if full title cant be shown
- Error message on no discounted game in genre should specify that there are no discounted games, not "no games"
- Entire page spread should be wider, there is a lot of empty space on the page
- Top 10 Games by Genre and Discounts by Genre filters should be stored in session storage
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was closed and merged by accident. Another PR for Update MainPage Display Sections will follow shortly with the correct and final changes.
.
.
This PR adds:
Note: Reviews and ratings for games are planned to be implemented in a future issue, as such this implementation is not displayed on the mainpage for this delivery.