Skip to content

Extract search field into a separate component #26

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2026
Merged

Extract search field into a separate component #26

merged 3 commits into from
Sep 16, 2026
+102 −59

Conversation

emmafre
Copy link
Member

@emmafre emmafre commented Sep 16, 2026 •
edited by minael
Loading

Moved filtering logic from CharactersPage.tsx to a new file filterCharacters.tsand created a seperate Searchbar component

Closes #25

@emmafre emmafre added this to the P1 milestone Sep 16, 2026
@emmafre emmafre requested a review from minael September 16, 2026 19:01
@emmafre emmafre self-assigned this Sep 16, 2026
@emmafre emmafre requested a review from a team as a code owner September 16, 2026 19:01
@emmafre emmafre linked an issue Sep 16, 2026 that may be closed by this pull request
Extract search field into a separate component #25
Closed
4 tasks
minael
minael approved these changes Sep 16, 2026
View reviewed changes
Copy link
Member

@minael minael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Good structure.

@emmafre emmafre merged commit 77813f4 into dev Sep 16, 2026
@emmafre emmafre deleted the 25-extract-search-field-into-a-separate-component branch September 16, 2026 19:38
Sign in to join this conversation on GitHub.
Reviewers

@minael minael minael approved these changes

Assignees

@emmafre emmafre

Labels
None yet
Projects
None yet
Milestone
P1
Development

Successfully merging this pull request may close these issues.

Extract search field into a separate component
2 participants
@emmafre @minael