Skip to content

Search, Filters and Favorites #8

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2026
Merged

Search, Filters and Favorites #8

merged 4 commits into from
Sep 15, 2026
+122 −69

Conversation

gurveers
Copy link
Member

Closes #7

@gurveers
feat: ✨ Search is now implemented
5aa4dac 
Search works as expected and you can write both upper and lower case
@gurveers
feat: ✨ Filters now work
0c51c29 
Filters works both alone and with search
@gurveers
feat: ✨ Favorite system works
f66490c 
You can now favorite characters, and the star will change color accordingly
@gurveers gurveers added the enhancement New feature or request label Sep 11, 2026
@gurveers gurveers added this to the P1 milestone Sep 11, 2026
@gurveers gurveers self-assigned this Sep 11, 2026
@gurveers gurveers requested a review from a team as a code owner September 11, 2026 08:56
emmafre
emmafre reviewed Sep 14, 2026
View reviewed changes
Copy link
Member

@emmafre emmafre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether this belongs under my earlier issue or this one, but when there are no search results (for example, when the species filter is set to “unknown”), the search bar becomes very small and the page layout changes. What do you think?

@gurveers
Copy link
Member Author

I'm not sure whether this belongs under my earlier issue or this one, but when there are no search results (for example, when the species filter is set to “unknown”), the search bar becomes very small and the page layout changes. What do you think?

Is that not more of a styling problem? I took this issue as being more of a functionality adding issue, the problem seems to be with the minimum width of the div or something accordingly. Correct me if I am wrong.

@emmafre
Copy link
Member

emmafre commented Sep 14, 2026

I'm not sure whether this belongs under my earlier issue or this one, but when there are no search results (for example, when the species filter is set to “unknown”), the search bar becomes very small and the page layout changes. What do you think?

Is that not more of a styling problem? I took this issue as being more of a functionality adding issue, the problem seems to be with the minimum width of the div or something accordingly. Correct me if I am wrong.

I agree. I can create a separate clean up issue addressing this and other small styling issues.

emmafre
emmafre approved these changes Sep 14, 2026
View reviewed changes
Copy link
Member

@emmafre emmafre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good functionality wise!

karenska
karenska approved these changes Sep 14, 2026
View reviewed changes
Copy link
Member

@karenska karenska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Gurveer!

minael
minael approved these changes Sep 14, 2026
View reviewed changes
Copy link
Member

@minael minael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gurveers gurveers merged commit 569604e into dev Sep 15, 2026
@gurveers gurveers deleted the issue7 branch September 15, 2026 10:10
@emmafre emmafre changed the title Issue7: Search, Filters and Favorites Search, Filters and Favorites Sep 16, 2026
@minael minael linked an issue Sep 16, 2026 that may be closed by this pull request
Implement search, filtering and favorites for the character list #7
Closed
15 tasks
@emmafre emmafre removed the enhancement New feature or request label Sep 16, 2026
Sign in to join this conversation on GitHub.
Reviewers

@karenska karenska karenska approved these changes

@emmafre emmafre emmafre approved these changes

@minael minael minael approved these changes

Assignees

@gurveers gurveers

Labels
None yet
Projects
None yet
Milestone
P1
Development

Successfully merging this pull request may close these issues.

Implement search, filtering and favorites for the character list
4 participants
@gurveers @emmafre @karenska @minael