Changes to styling for functionality #81
Merged
+504
−217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now a arrow point down to the paintings with indicates that you should scroll down to see the content.
You can now navigate better throughout the page with tab, space, arrow buttons and escape.
The filter and search bar now sticks to the page for easier control, filters will also stick to make it easier to filter after scrolling down. The profile button is also in the new sticky bar.
It is now possible to add the paintings to a galery directly from the main artwork page.
When tapping next page, it will now scroll to the top off the page, not stay on the bottom. When scrolling to previous page it will not scroll up.
There is now a dark theme option (made entirely by AI, to save time), it changes the hero pages to.
Buttons such as Back and Logout did not have a background, now they are easier to see, on some backgrounds.
gurveers
added
enhancement
the posistioning now does not reset every time you go out.
The background behind the art is now black in dark theme.
emmafre
changed the title
emmafre
removed
enhancement
7 tasks
|
Wow, lots of new changes! I really like the dark mode addition, but I think the toggle button should also be in the sticky navbar. The navbar itself is perfect for what we discussed and serves its purpose well! However, I feel the arrow in the hero section is a bit unnecessary and adds some visual clutter. What do you think? @minael @gurveers |
The theme button now also appears in the sticky bar.
There is now different styling for mobile and desktop for sticky bar.
The hero now looks much better on a phone than it were previously.
The hero title and text is now centered on the screen
the '+' is now removed when in your own gallery.
minael
approved these changes
Nov 6, 2026
There was a problem hiding this comment.
Looks very good overall! The dark mode implementation and styling changes seem consistent across the app, and the accessibility considerations look solid.
Two small non-blocking comments that could also be looked at later:
- The new dark hero images are quite large compared to the existing assets, so it could be worth compressing/resizing them for performance and sustainability.
- Since both light and dark hero variants are rendered and switched with opacity, both image sets may be loaded even though only one is visible at a time.
Otherwise, this looks good to me.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many changes here and should be looked out carefully.
Closes #80