feat: Browse page #50
Merged
+108
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add data/mockBooks.ts, which loads the backend's test-data/books.json and maps it into the client's Book shape (googleBooksId -> id). Saved/favorited books are not persisted: bookmark buttons reset on page reload. Update App.tsx to render the actual BrowsePage instead of the placeholder. BrowsePage itself is unchanged.
feat: add temp data adapter for browse page
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add BrowsePage with BookCard grid. More features will be added when other parts of the app are implemented by the team.
Uses temporary file
client/src/data/mockBooks.tsto map book data fromserver/test-data/books.jsonto show example books.App.tsx is modified to now show the actual browse page instead of the placeholder.
Note: several elements are temporary and will be addressed later when looking at accessibility, visual design cohesiveness across the app, and implementation of Apollo and queries in frontend.
Note 2: Branch and work mainly by Line Sofie Flaate. PR opened by Ilse Resell due to LS not being available to do it at the time.
Closes #24