Skip to content

Conversation

wilhelsr
Copy link
Member

Purpose

Allow users to scroll and interact with the page while success notifications are visible.

Changes

  • Replace the success notification’s modal dialog with a non-modal popover.
  • Preserve the notification’s position, close button, optional action, timer, and slide animation.
  • Keep confirmation dialogs modal.

Related issues

None.

Verification

  • npm test: all 24 tests passed.
  • ESLint and Prettier checks passed for SuccessNotification.tsx.
  • npm run build: blocked by an existing unused useNavigate import in AddToBuildButton.tsx.
  • Manual browser verification remains: add or remove a component, scroll while the notification is visible, and check its close button, action, and automatic dismissal.

Screenshots

Not applicable — the notification’s appearance is unchanged.

Checklist

  • I have reviewed my own changes.
  • The changes meet the linked issue's acceptance criteria, where applicable.
  • I have verified the changes and recorded the results above.
  • I have included screenshots for visual changes, or marked them not applicable.

@wilhelsr wilhelsr requested a review from a team as a code owner November 12, 2026 18:41
@wilhelsr wilhelsr linked an issue Nov 12, 2026 that may be closed by this pull request
@wilhelsr wilhelsr changed the base branch from main to dev November 12, 2026 18:41
@krgjert krgjert added this to the 4. underveisinnlevering milestone Nov 12, 2026
@krgjert krgjert added the bug Something isn't working label Nov 12, 2026
Copy link
Member

@krgjert krgjert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great bug fix!

@krgjert krgjert merged commit 1c70858 into dev Nov 12, 2026
@krgjert krgjert deleted the 111-fix-no-scroll-while-notifications-are-showing branch November 12, 2026 18:49
Sign in to join this conversation on GitHub.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix no-scroll while notifications are showing
2 participants