feat: add useBooks hook and integrate the book viewer #17
+251
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- src/hooks/useBooks.ts: TanStack Query useQuery keyed ['books', subject] over searchBooksBySubject, exposing books/isLoading/isError - App: hardcoded fantasy subject (replaced by persisted choice in M3), loading (role=status), error (role=alert) and empty states, BookCard wired into a book viewer region - test infra: msw server + OpenLibrary handlers (request counter for cache assertions), QueryClient test providers, global onUnhandledRequest error so tests never touch the network - tests: hook caching (fetch count stays 1 across re-renders), App loading/error/empty/first-book, App snapshot updated deliberately (-u) Navigation and jump-list wiring lands in this PR as #13/#14 merge. Closes #12
erikhfj
added
type: feature
robertky
requested changes
Sep 7, 2026
There was a problem hiding this comment.
Looks good overall. One question before merging: this PR closes #12, but #12 also includes wiring NavigationControls and BookJumpList into App.
Since #13 and #14 are still being worked on, should we keep #12 open until that integration is complete, or move the integration to a separate issue? Otherwise, the issue may close before all its tasks are finished.
robertky
approved these changes
Sep 8, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the data hook + App integration from #12 (issue stays open until navigation and jump list are wired in — per review agreement):
useBooks(subject): TanStackuseQuerykeyed['books', subject]oversearchBooksBySubject; exposesbooks / isLoading / isErrorfantasysubject (becomes the persisted choice in M3), loading state (role=status), error state (role=alert), empty state, BookCard in a labeledbook viewerregionQueryClienttest providers, and globalonUnhandledRequest: error— tests physically cannot touch the networkTest evidence
vitest -u)Checklist
npm run lint— 0 warningsnpm test— 14 passednpm run build— passesnpm run format:check— passesAI-assisted: implementation generated with AI assistance, reviewed and verified.