feat: wire subject filter into the viewer with index reset #27
+26
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- App: hardcoded SUBJECT replaced by usePreferences (sessionStorage, t19.preferences); SubjectFilter rendered above the viewer - subject change resets the book index so the stale index can never point outside the new list - test setup: sessionStorage and localStorage cleared between tests - tests: subject change refetches exactly once for the new subject, choice restored from sessionStorage on mount, corrupt storage falls back to the default subject; snapshot updated deliberately Partial #22: subject filter wired; sort (#20) and favorites (#21) wiring follows when those merge.
erikhfj
added
type: feature
robertky
reviewed
Sep 10, 2026
There was a problem hiding this comment.
PR #26 has now been merged, so this PR currently conflicts with main. Could you rebase it onto the latest main and resolve the conflict?
After the rebase, this PR should only contain the subject-change reset and its related tests, since navigation and the jump list are already in main. Please let CI run again afterwards, and I can review it then.
Resolved App.tsx in favor of main's favorites integration (FavoritesView, BookCard favorite props) and re-applied the subject-change index reset. The subject-change test now navigates first so the reset is observable: changing subject returns to the first book at 1 / N. Snapshots regenerated.
Resolved in favor of main's sort integration (SortSelect, sortedBooks) and applied consistent reset UX: changing subject OR sort returns to the first book, so both preference changes behave identically. Both reset tests now navigate first, making the reset observable (position and heading asserted). Also consolidated the review notes: isSortOption now derives from SORT_OPTIONS (single source of truth) and DEFAULT_SORT is no longer exported. Snapshots regenerated.
robertky
approved these changes
Sep 12, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Completes #22 (and remains the vehicle for the M3 integration). Three slices, now all in this branch:
usePreferences(sessionStorage,t19.preferences) — choice survives reloadFavoritesView+BookCardfavorite propsAlso folded in the #29 review notes:
isSortOptionnow derives fromSORT_OPTIONS(single source of truth) andDEFAULT_SORTis no longer exported.Tests (51 green across 12 files)
1 / 3sessionStoragefor subject AND sort (corrupt storage falls back safely)Checklist
npm run format:check— passesnpm run lint— 0 warningsnpm test— 51 passednpm run build— passesCloses #22.
AI-assisted: implementation generated with AI assistance, reviewed and verified.