Skip to content

Conversation

jonatsm
Copy link
Member

@jonatsm jonatsm commented Oct 1, 2026

Sighting detail page

Clicking a sighting in the list opens it on its own page.

What's included

  • react-router with hash URLs: /#/sightings/:id. Works on the VM with no server setup.
  • Detail page with a larger map you can drag and zoom, plus the same content as in the listview. Can add/change content later
  • Clicking anywhere on a list item opens it. Only the heading looks like a link
  • The search and sort are saved in the URL (?q=...&sort=...), so "Back to results" and refresh keep them
  • The map and the formatting functions moved out of SightingList into shared files
  • Map thumbnails in the list can no longer be zoomed or tabbed to

How to test

  1. npm install (new dependency), then npm run dev
  2. Search, open a sighting, go back. The search should still be there.
  3. Open /#/sightings/999 to see the "not found" page.

Closes #9

vitaliyb and others added 3 commits September 28, 2026 13:24
ADd react-router with hash URLs so each sighting has its own
page at /#/sightings/:id. The detail page shows a bigger map
then the listview, but as of now contains all the same content.

Store the search query and sort order in the URL so they survive
navigation and refresh. Also move the map and formatters out of
SightingList into shared files so both view can use them.

Refs #9
Clicking the map, title or anything in the sighting listview
now navigates to the detailed view for that sighting.

Refs #9
@jonatsm jonatsm added the feat New feature label Oct 1, 2026
@jonatsm jonatsm added this to the Partial submission 1 milestone Oct 1, 2026
@jonatsm jonatsm requested a review from a team as a code owner October 1, 2026 08:44
@jonatsm jonatsm linked an issue Oct 1, 2026 that may be closed by this pull request
asgeija
asgeija previously approved these changes Oct 1, 2026
Copy link
Member

@asgeija asgeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thortve
thortve previously approved these changes Oct 1, 2026
@thortve thortve dismissed stale reviews from asgeija and themself via cc796d5 October 1, 2026 09:02
Copy link
Member

@thortve thortve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Ready to merge.

@thortve thortve merged commit f38a5f8 into main Oct 1, 2026
@asgeija asgeija deleted the 9-build-the-detail-view-for-an-object branch October 1, 2026 09:35
Sign in to join this conversation on GitHub.
Labels
feat New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build the detail view for an object
4 participants