Skip to content

Conversation

vitaliyb
Copy link
Member

@vitaliyb vitaliyb commented Oct 6, 2026

*Tables created
*Script for cleaning and inserting data is created
*All scripts and data are copied to the vm

@vitaliyb vitaliyb requested a review from a team as a code owner October 6, 2026 12:12
@vitaliyb vitaliyb linked an issue Oct 6, 2026 that may be closed by this pull request
3 tasks
Copy link
Member

@asgeija asgeija left a comment •

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good import script, it runs and the cleaning looks good. I think we should change these before merging:

Setup: nothing creates the project_2_db database or an app user, and create-tables.sql fails if you run it twice. The install script and importer also use sudo mysql and an interactive mysql_secure_installation, so nobody else can run them on the VM.

Import checks: INSERT IGNORE can hide errors, and we never check that the inserted rows match the CSV.

Missing values: missing country and state are saved as empty strings. Could we use NULL instead?

ufo_sightings_clean.csv, _rejected.csv, _issues.csv should go in .gitignore, since they can be recreated from the raw CSV.

Copy link
Member

@asgeija asgeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

@vitaliyb vitaliyb merged commit 9cee19e into main Oct 8, 2026
1 check passed
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up the database on the VM
2 participants