Feat: Add createSighting mutation and validation #56
+759
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add createSighting(input: CreateSightingInput!): Sighting! for #37. Input is validated on the server: required fields, text lengths that match the VARCHAR columns, latitude -90..90, longitude -180..180, duration 1 s to 1 year, and a real local datetime from 1900 that is not in the future. All invalid fields are reported at once as a BAD_USER_INPUT error with fieldErrors in the extensions. Add IS_USER_SUBMITTED to UFO_SIGHTINGS, exposed as Sighting.userSubmitted, so user rows can be told apart from NUFORC rows without a login. Add a backend test script (node --test) with unit tests for the validation. TODO: - Store the sighting. insertSighting in src/db/sightings.ts is a stub that throws NOT_IMPLEMENTED until the MySQL layer exists (#31). It should find or create the LOCATIONS and SHAPES rows and insert with DATE_POSTED = NOW() and IS_USER_SUBMITTED = TRUE in one transaction. - Migrate the existing VM database. CREATE TABLE IF NOT EXISTS does not add the new column to a table that already exists, so run ALTER TABLE UFO_SIGHTINGS ADD COLUMN IS_USER_SUBMITTED BOOLEAN NOT NULL DEFAULT FALSE once. - Map IS_USER_SUBMITTED to userSubmitted in the sighting and sightings resolvers when they are written (the field is non-null). - Get group agreement on the schema change: the mutation, the input fields and limits, userSubmitted and the error format. - Connect SubmitSightingPage to the mutation instead of the local mock store. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks
Merge main to get the MySQL pool and sighting queries from #28, and build on them so createSighting stores sightings for #37. insertSighting runs in one transaction. It reuses or creates the LOCATIONS and SHAPES rows, using <=> for nullable columns like the import script, then inserts with DATE_POSTED = NOW() and IS_USER_SUBMITTED = TRUE. City, state and country are lowercased to match the imported data. The sighting queries now return userSubmitted. SubmitSightingPage now calls the mutation instead of the mock store. Server field errors are shown next to their fields, and other failures show a general message. The datetime is sent as local time, since the server rejects UTC with Z. The created sighting is also added to the local store so the detail link works until the list and detail pages read from GraphQL. The VM database needs the IS_USER_SUBMITTED column before deploying, or the sighting queries fail. Closes #37 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thortve
added
enhancement
|
Youre good, LGTM. |
asgeija
approved these changes
Oct 12, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add createSighting(input: CreateSightingInput!): Sighting! for #37. Input is validated on the server: required fields, text lengths that match the VARCHAR columns, latitude -90..90, longitude -180..180, duration 1 s to 1 year, and a real local datetime from 1900 that is not in the future. All invalid fields are reported at once as a BAD_USER_INPUT error with fieldErrors in the extensions.
Add IS_USER_SUBMITTED to UFO_SIGHTINGS, exposed as Sighting.userSubmitted, so user rows can be told apart from NUFORC rows without a login. Add a backend test script (node --test) with unit tests for the validation.
TODO: