34 connect search and the list view to the backend #58
+704
−250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow null in every UfoSighting field except id, like the Sighting type in the schem, and show readable fallbacks when values are missing. Map the URL sort names to the API's SightingSort enum. Refs #34
Query one page of sightings with search, sort and cursor variables, including totalCount and pageInfo for the result count and "load more". Types so useQuery knows the shape of data and variables. Refs #34
Replace the in-browswer filtering in useSightingSearch with the sightings query, so search and sort run on the whole dataset in the database. Keep the debounce and URL state, and trim the search so trailing spaces do not send new requests. Tests now check which requests the page sends instead of how mock data is sorted. Refs #34
Show a loading message before the first results, keep previous results visible but dimmed while a new search loads, and show an error with a retry button if the backend fails. Refs #34
Fetch the next page with the end cursor and append it in the Apollo cache, keyed by search, filter and sort so each search keept its own list. Show "showing X of Y" progress, keep focus on the button while loading, and offer a retry if a page fails. Refs #34
Delete filter-sightings and its tests now that search and sort run in the database. Update comments that described the old filtering, and bring AGENTS.md's current state and folder notes up to date. Refs #34
jonatsm
added
feat
4 tasks
asgeija
deleted the
34-connect-search-and-the-list-view-to-the-backend
branch
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect search and list to the backend
The search page now gets its results from the database through GraphQL instead of filtering mock data in the browser.
useSightingSearchuses thesightingsquery. Search and sort still live in the URL, and the 300 ms debounce is kept.nulllike the schema, with fallbacks such as "Unknown" and "No map location"filter-sightingsand its tests; updated AGENTS.mdTests check which requests are sent: one per search after typing stops, none for a repeated search, and paging/retry.
Known limitations
SHAPE_ASCsorts sightings without a shape first. That's for the resolver.How to test
backend/.envfilled in from.env.examplenpm run dev:backendandnpm run devAI usage
Claude Code helped plan and implement the hook, cache rules, UI states and tests, and debug the local DB setup.
Closes #34