Test: Update component tests for Apollo #71
Merged
+226
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give the fake backend an optional latency so states that only exist while waiting can be tested, and test the first load, a serach with no matches and a new serach while old results are shown. Refs #43
…e-backen' into 43-update-component-tests-for-apollo
The summary counted keys in the errors object, but fixing a field set its error to undefined without removing the key. Now it checks for actual messages instead. Fixes #63
Check that an invalid form sends no request and links each error to its feild, that the error summary goes away once the fileds are fixed, that a double click sends on requests, and that a sbmitted sighting shows up in the search list. Uses a fake database that stores the sighting and counts requests. Refs #43, #64
npm test started Vitest in watch mode and only reached the backend tests after quitting it. Run Vitest once by default, like CI, and moved watch mode to npm run test:watch. Documented in AGENTS.md. Refs #43
node --test only runs .ts files by itself from Node 22.18, so npm test failed with ERR_UNKNOWN_FILE_EXTENSION on older Node 22 version. Now the tests are ran through tsx instead, and Node 22 is set as the minimum version in package.json. Refs #43
jonatsm
approved these changes
Oct 15, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #67, which got stuck. Same commits (by @jonatsm), merged with the latest
main.Closes #43
What changed
SubmitSightingPage.tsx).npm run testnow runs the frontend (Vitest) and backend tests once, as CI does.tsx. Running the.tstest file directly gaveERR_UNKNOWN_FILE_EXTENSIONon some Node versions. The same fix is inb1972db.AGENTS.mdupdated to match the new test commands.Review history from #67
ERR_UNKNOWN_FILE_EXTENSIONwhen runningnpm testand asked for the backend test script to run throughtsx.b1972db, and @asgeija confirmed thatnpm testworks.main.The commits are unchanged apart from the merge with
main, so this needs a fresh approval but should not need new code review.Testing
npm run lintnpm run testComponent tests mock Apollo, so no backend or database is needed.
AI usage
Claude Code was used to copy this PR onto a new branch. The code changes are the original work from #67.