-
Notifications
You must be signed in to change notification settings - Fork 0
mainpage Grid Layout #19
Merged
+151
−26
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,54 @@ | ||
| function App() { | ||
| return <> | ||
| <header> | ||
| <h1>PokeDOX</h1> | ||
| <input type="search" placeholder="Search"></input> | ||
| </header> | ||
| <main> | ||
| // Mock data until we have a backend: 12 pokemon with id, name and placeholder url | ||
| const mockNames = [ | ||
| 'Bulbasaur', | ||
| 'Ivysaur', | ||
| 'Venusaur', | ||
| 'Charmander', | ||
| 'Charmeleon', | ||
| 'Charizard', | ||
| 'Squirtle', | ||
| 'Wartortle', | ||
| 'Blastoise', | ||
| 'Caterpie', | ||
| 'Metapod', | ||
| 'Butterfree', | ||
| ]; | ||
|
|
||
| const mockPokemon = mockNames.map((name, i) => ({ | ||
| id: i + 1, | ||
| name, | ||
| url: '#', | ||
| })); | ||
|
|
||
| </main> | ||
| <footer> | ||
| <span>Doxing all your favourite pokemon since 2026</span> | ||
| </footer> | ||
| </>; | ||
| function App() { | ||
| return ( | ||
| <> | ||
| <header> | ||
| <h1>PokeDOX</h1> | ||
| <input | ||
| type="search" | ||
| placeholder="Search" | ||
| aria-label="Search pokemon" | ||
| ></input> | ||
| </header> | ||
| <main> | ||
| <ul className="pokemon-grid"> | ||
| {mockPokemon.map((pokemon) => ( | ||
| <li key={pokemon.id} className="pokemon-card"> | ||
| <div className="pokemon-image"> | ||
| <img src={pokemon.url} alt={pokemon.name} /> | ||
| </div> | ||
| <h2>{pokemon.name}</h2> | ||
| <span>#{String(pokemon.id).padStart(4, '0')}</span> | ||
| </li> | ||
| ))} | ||
| </ul> | ||
| </main> | ||
| <footer> | ||
| <span>Doxing all your favourite pokemon since 2026</span> | ||
| </footer> | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| export default App; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably keep the package lock as is, but it's not a problem