refactor: unify server schema and simplify pokemons query #62
+247
−519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the complete GraphQL schema and resolvers into server/schema.ts, so the API tests now run against the same code as the server. server/index.ts only seeds the database and starts the server. Replace the four SQL branches in the pokemons resolver with one query built from a list of conditions, and remove the unused SORT_COLUMNS object and sort enums. Add API tests for ratePokemon, sorting by own rating, and combined filter, cursor and sort. Issue: #60 Co Author: Pederoha, Copilot Luna 5.6
pederoha
approved these changes
Nov 11, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the complete GraphQL schema and resolvers into server/schema.ts, so the API tests now run against the same code as the server. server/index.ts only seeds the database and starts the server.
Replace the four SQL branches in the pokemons resolver with one query built from a list of conditions, and remove the unused SORT_COLUMNS object and sort enums. Add API tests for ratePokemon, sorting by own rating, and combined filter, cursor and sort.
closes #60
Co Author: Pederoha, Copilot Luna 5.6