3 chore setup vitest #30
Merged
+936
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronjalh
force-pushed
the
3-chore-setup-vitest
branch
from
9e7c1e6 to
3c42867
Compare
anettkva
reviewed
Sep 9, 2026
There was a problem hiding this comment.
Since we will be testing components (props, state, user interaction) and doing snapshot tests, don't we need a DOM available for that? Node doesn't have document/window, so I'd expect those future test to fail. Should we switch to jsdom here (and add it as a dev dependency)?
anettkva
approved these changes
Sep 11, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.