Skip to content

Conversation

ronjalh
Copy link
Member

@ronjalh ronjalh commented Nov 6, 2026

Add the About page

Closes #146

The About page was a placeholder. It now introduces the site, explains the sport for people who do not know gymnastics, and says where the data comes from.

What the page says

Part Content
Our mission Make the knowledge of the Code of Points PDF available for search and for calculating scores, for trainers and their gymnasts
Gymnastics in two minutes A glossary: apparatus, routine, element (with the full A–J values), vault (why it has no letter), D-score, E-score, final score, Code of Points
The Code of Points and our data Link to the official PDF (about 24 MB) and to the rules page of FIG, that we do not own the content, that the project is not affiliated with FIG, and that the catalog may not have the latest changes
For trainers That the site is made especially for trainers and why there is a login, that the login is a test login, and what the calculator does not support yet (composition requirements, connection values, bonuses, the E-score)

Choices

  • Very simple: plain text with links. No cards and no buttons of its own.
  • Light and dark mode: only theme colors, so both work.
  • The facts were checked against the PDF: the A–J values, that the D-score on vault is the value of the vault, the 0.20 dismount bonus, and the final score. The PDF link was checked: it answers with a PDF.
  • src/lib/codeOfPoints.ts holds the two links, so they are in one place.
  • global.css: .about-page is added to the two heading rules that the Elements and gymnasts pages use, so the headings look the same.

Testing

  • Component tests (src/tests/pages/AboutPage.test.tsx): title, one h1 and h2 for each part, sections named by their headings, the PDF link, the rights text, the trainers and login text, links, and that there are no buttons.
  • tsc -b, ESLint and all 328 frontend tests pass.
  • axe-core: no violations in light and dark mode, and no horizontal scroll at 320 px.

Not in this PR

🤖 Generated with Claude Code

Introduce the site and the sport for people who do not know
gymnastics, link the official Code of Points PDF, say that the
content is not ours, and explain that the site is made for trainers
and why it has a login. Plain text with links, in light and dark mode.

- add a glossary: apparatus, routine, element with the A-J values,
  vault, D-score, E-score, final score and Code of Points
- say what the calculator does not support yet: composition
  requirements, connection values, bonuses and the E-score
- add component tests for the PDF link, the rights text, the heading
  order and that the page has no buttons
- add the About page to docs/AI_USAGE.md

Closes #146
@ronjalh ronjalh requested a review from a team as a code owner November 6, 2026 13:20
@ronjalh ronjalh self-assigned this Nov 6, 2026
Ronja added 2 commits November 6, 2026 14:34
Keep the tests of the structure, the login text, the limits of the calculator and the links. The tests of the mission, the glossary and the PDF and rights text only checked that words were present, so they broke on any rewording.
Replace the line that said nothing was committed or posted with what the team changed after the first version: the trainers and the login, the A-J mapping, routines and vaults, and what the calculator does not support yet.
@anettkva
Copy link
Member

Nice, clear page, and the facts hold up: I checked them against our data (the digit after the dot is the difficulty for all 749 elements, and vault goes from 1.6 to 6.4). tsc, lint, Prettier, the build and all 321 frontend tests pass, and it reads well in dark mode.

One thing: the "Element" text uses the word "grade" ("The grade is a letter…", "The code tells the grade"), which is not used anywhere else on the webpage. Could it say "difficulty" instead, like the rest of the webpage?

Generated with Claude Code, from my review.

Ronja added 2 commits November 10, 2026 14:14
The rest of the site calls the letter of an element its difficulty.

Refs: #146
# Conflicts:
#	docs/AI_USAGE.md
#	src/styles/global.css
@xeniag xeniag merged commit 1f9a409 into dev Nov 10, 2026
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants