Skip to content

Conversation

ronjalh
Copy link
Member

@ronjalh ronjalh commented Nov 7, 2026

What

Removes the files and CSS that the Vite template left behind. Part of the peer feedback in #167.

  • Deleted src/assets/hero.png, react.svg, vite.svg, src/App.css and public/icons.svg. None of them is imported or referenced anywhere in src/, index.html or the docs (checked with a search).
  • Removed from src/index.css the rules and tokens that only the template used: .counter, #social .button-icon, --accent-bg, --accent-border, --social-bg and --shadow (nothing reads them).
  • Updated the comment at the top of src/index.css, which said that the starter styles would go.

Not changed on purpose

The rest of the starter styles in src/index.css is still in use and changes how every page looks: the #root width and border, the h1/h2 sizes, p, code, and the --text, --bg, --border tokens on :root (including the dark block for visitors without a stored theme). Removing them is a visual change and needs a check of every page, so it is better as its own issue (it also touches #161 and #168).

Checked

  • npm run build passes, tsc -b is clean and the frontend tests pass (402).
  • The backend tests need a database and could not run in this clean worktree.

Closes #180

🤖 Generated with Claude Code

Delete the unused src/assets files (hero.png, react.svg, vite.svg), the
unused src/App.css and public/icons.svg. Remove the dead rules and tokens
of the template from src/index.css (.counter, #social, --accent-bg,
--accent-border, --social-bg, --shadow).

Closes #180
@ronjalh ronjalh requested a review from a team as a code owner November 7, 2026 15:38
@ronjalh ronjalh self-assigned this Nov 7, 2026
@anettkva
Copy link
Member

Nice cleanup! tsc, lint, Prettier, the build and all 312 frontend tests pass, and nothing uses the deleted files or CSS variables.

Before merge: the README still mentions src/App.css (line 143: "A rule in src/index.css or src/App.css therefore overrides a utility class…"). Since this PR deletes it, that line should reflect that:)

Generated with Claude Code, from my review.

@xeniag xeniag merged commit 2548cb0 into dev Nov 10, 2026
@xeniag xeniag deleted the 180-remove-the-leftovers-of-the-vite-template branch November 10, 2026 19:39
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants