Update API URL and Vite proxy configuration for project structure #188
+92
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xeniag
commented
Nov 9, 2026
xeniag
commented
- Changed default API URL from '/graphql' to '/project2/graphql' in Apollo client.
- Updated Vite configuration to add a proxy for '/project2/graphql' to forward requests to the backend.
- Changed default API URL from '/graphql' to '/project2/graphql' in Apollo client. - Updated Vite configuration to add a proxy for '/project2/graphql' to forward requests to the backend.
ronjalh
reviewed
Nov 9, 2026
There was a problem hiding this comment.
Speed Claude review, dobbeltsjekk det så burde det være good:
Det er likevel tre ting jeg ville kommentert på PR-en:
'/graphql' er nå overflødig. Hvis klienten alltid bruker /project2/graphql, treffer ingen den gamle regelen. Den kan fjernes, ellers ser det ut som det finnes to gyldige stier.
/images er ikke flyttet. Hvis bilder også går via /project2/ på VM-en, vil de virke lokalt, men gi 404 i produksjon, eller omvendt. Det bør behandles likt som graphql.
/project2 er hardkodet. Det er ryddigere å sette prefikset ett sted, nemlig base i Vite:
// vite.config.ts
base: '/project2/',
ronjalh
requested changes
Nov 10, 2026
package-lock.json
Outdated
The lockfile changes in 1cfdae8 were unrelated dependency bumps (no package.json changed), so the lockfile now matches main again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Matches the backend's new default port from f5c286a. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.