refactor(tests): split the ElementsPage test file by topic #191
+1,439
−1,301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 1375-line file becomes eight files of at most 260 lines (the page, the filters, the filters and the address, the sort, the combined cases, the results, the search and Load more), with the shared set-up in src/tests/elementsPage.tsx. No test is changed: 64 tests before and after. Closes #181
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Splits
src/tests/pages/ElementsPage.test.tsx(1375 lines) by topic, as asked in the peer feedback (#167).ElementsPage.test.tsxElementsPage.filters.test.tsxElementsPage.filtersAddress.test.tsxElementsPage.sort.test.tsxElementsPage.combined.test.tsxElementsPage.results.test.tsxElementsPage.search.test.tsxElementsPage.loadMore.test.tsxThe shared set-up (the stub server,
renderPage, the menu helpers) is insrc/tests/elementsPage.tsx.Checked
tsc, ESLint and Prettier are clean. The README names the new files.eslint-disableforreact-refresh/only-export-components, because it exports both components and functions and is not part of the app.Closes #181
🤖 Generated with Claude Code