fix(elements): make the result cards and the title more compact on a phone #199
+42
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…phone The drawing is to the right of the text below 600 px, the padding and spacing are smaller, and the title of the Elements page is 40 px (was 34 px). The cards are 162 to 182 px high (were 334 to 372 px). Closes #169
… a row on a phone The drawing was 96 px wide and could not be understood. It is now under the text, at most 112 px high, and the apparatus, the element group and the difficulty are in a row that wraps below 600 px. Refs #169
…he compact cards Refs #169
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Makes the result cards and the title of the Elements page more compact on a phone (peer feedback, #167).
Measured
Real browser, first page of results, light theme:
No sideways scroll at 320, 360 or 390 px. I first tried a drawing next to the text (cards of 162–182 px), but at 96 px wide the drawing could not be understood, so it is under the text.
Not met: the issue asks for about twice as many results on the first screen. A card is about 20 % shorter, and one card is still fully on the first screen. The filters take four rows at the top of a phone; making them smaller is a separate change.
Checks
tsc, eslint and prettier are clean; 183 tests insrc/tests/components/elementsandsrc/tests/pagespass. The e2e accessibility tests were not run for this change.Refs #169
🤖 Generated with Claude Code