feat(elements): make the hover effect of buttons and result rows clearer #205
+210
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buttons get a 2 px edge on hover and when pressed, "Clear filters" turns to the danger color, and the text shadow of the rows is replaced by a 4 px edge on the first cell. An e2e test measures the edge and the danger color in both themes. Closes #171
added 8 commits
November 11, 2026 19:18
The menu popup is almost the color of the page, so it gets a 1 px edge in the text color like the search field. The choice under the pointer or the keyboard gets the text color of the buttons and a 2 px edge inside it: the text color of dark mode was 1.5:1 on the light tan of a highlighted choice. Refs #171
…on in their row on a phone An open menu button keeps the text color of the button (the Button variant made it white, 2.4:1 on the tan button of dark mode). A button that cannot be used does not react to the pointer. Below 600 px the sort button shares the row of the last filter when there is room. Refs #171
…lighted choice and the disabled filter Refs #171
… hover effect Refs #171
…sabled ones still The choice under the pointer or the keyboard is navy with light text in light mode and light tan with dark text in dark mode, instead of the near-invisible beige and light text on light tan. No edge on pointer hover. A choice that cannot be chosen is not highlighted by the pointer, and the keyboard gets a 2 px edge there. Refs #171
…and keep Clear filters red An open or pressed button has the colors of a highlighted menu choice. The pressed Clear filters is red, as on hover. Refs #171
…lighted by the pointer Refs #171
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Makes the hover and pressed state of the buttons, the menus and the result rows clear in both themes (peer feedback, #167). The first version was tried by hand, and the states it had not covered were fixed (see
docs/AI_USAGE.md).aria-disabled) does not react. While its menu is open, or while it is pressed (active:, which a phone needs), it has the colors of a highlighted menu choice, so the state can be seen. It was white text on the tan button in dark mode, 2.4:1.--danger) on hover and when pressed.--menu-highlight-bgand--menu-highlight-text). A choice that cannot be chosen is not highlighted by the pointer; the keyboard gets a 2 px edge there.display: contentsthere and is still a group named "Filters" in the accessibility tree).Measured
Real browser (Chromium), light and dark:
Checks
tsc, eslint and prettier are clean; 330 tests insrc/tests/components,src/tests/pagesandsrc/tests/stylespass. 15 end-to-end tests pass (e2e/hover.e2e.tsis new and measures the edge, the danger color, the open button, the menu edge, the highlighted choice and the choice that cannot be chosen, in both themes; plus the accessibility and the elements flow tests). The full test run was not completed here. Only Chromium is checked. The rows still have no color change in light mode (the design has none).Closes #171
🤖 Generated with Claude Code