Skip to content

Conversation

ronjalh
Copy link
Member

@ronjalh ronjalh commented Oct 10, 2026 •

Summary

The repository had both package-lock.json and pnpm-lock.yaml, so dependency versions could differ between developers, and not everyone can run pnpm locally. npm is now the only package manager.

  • Removes pnpm-lock.yaml and the pnpm entries in .gitignore and .prettierignore.
  • Adds package-lock.json to .prettierignore. It is generated by npm, so Prettier should never rewrite it.
  • The README uses npm ci and npm run ..., and says that the project uses npm.
  • Declares the Node version in engines in package.json.

package-lock.json is not part of the diff because it is already tracked on main. This PR does not change it.

Testing

From a clean checkout (node_modules removed): npm ci, npm run lint, npm run build and npm test all pass.

Closes #30

🤖 Generated with Claude Code

Remove pnpm-lock.yaml and pnpm references, document npm in the README and declare the Node version in engines.
@ronjalh ronjalh self-assigned this Oct 10, 2026
@ronjalh ronjalh requested a review from a team as a code owner October 10, 2026 11:37
@ronjalh ronjalh linked an issue Oct 10, 2026 that may be closed by this pull request
6 tasks
Copy link
Member

@anettkva anettkva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is a clean switch! Two questions before we merge:

  1. Should we add package-lock.json? The PR deletes pnpm-lock.yaml but I can't see npm's lock file in the changes, and the README now uses npm ci, which needs it. Could you run npm install and commit the generated package-lock.json, or is it left out on purpose?
  2. Should package-lock.json go in .prettierignore? The PR removes pnpm-lock.yaml from it. Since the npm lock file is also generated, would it make sense to ignore it too, so Prettier never touches it?

@ronjalh
Copy link
Member Author

ronjalh commented Oct 14, 2026

  1. package-lock.json is already tracked on main (added in chore: setup vitest), so it does not show up in the diff. The PR only deletes pnpm-lock.yaml. npm ci works from a clean checkout; I ran npm ci, lint, build and tests to confirm.
  2. Good point. Prettier does not ignore lock files by default, so I added package-lock.json to .prettierignore in d97887b.

@anettkva anettkva merged commit e7672eb into main Oct 14, 2026
@anettkva anettkva deleted the 12-use-npm-only branch October 14, 2026 09:03
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: move from pnpmn to npm
2 participants