67 your gymnasts page #68
Open
+312
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeniag
reviewed
Oct 19, 2026
There was a problem hiding this comment.
Looks good! Just two quick accessibility improvements to consider:
- Add heading structure to
GymnastList: SinceYourGymnastsPagerenders the main<h1>Your gymnasts</h1>and the form uses an<h2>, passing an<h2>heading into<GymnastList>(or wrapping the list under a labeled section/heading) ensures screen reader users navigating by headings can jump straight to the list content. - Move screen reader live region higher in DOM order: Placing the live region
<p className="sr-only" role="status" aria-live="polite">before dynamic content mounted above it (or static at the container root) guarantees screen readers register the live region listener on initial render before text changes occur.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.