fix(api): update getPokemonByID guard to reject id < 1 (#29) #32
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushb
approved these changes
Sep 17, 2026
There was a problem hiding this comment.
Checked this out and ran it: tsc, eslint and the full suite pass. The guard now matches what the error message already claimed.
One thing worth adding while you're in here: the api tests cover -1 and 1025 but not 0, so nothing actually pins the new boundary. A case for id 0 would lock in the thing this PR fixes.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #29 by updating the guard condition in
src/api/pokemon.tsfromid < 0toid < 1.Changes Made
getPokemonByIDtoid < 1 || id > 1025.Related Issue
Closes #29