-
Notifications
You must be signed in to change notification settings - Fork 0
Miscellaneous - Margin, Generate Button, Title #37
Merged
+8,666
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ayseza
commented
Sep 16, 2026
- Removed margin from the body.
- Touched up generate button a bit.
- Realized title was still "Læringsområde...". Changed that to PTG.
- Added margin to name textbox, since removing margin from body applied to that too.
Added a grid of pokemon pulling the name and image from the PokeAPI api.
Added filter fundtionality for the grid of pokemon cards. Filter now saves with html storage and pulls names from PokeAPI to autoupdate incase of new added gens or types.
Added another filter to see pokemon from a specific game.
Added some comments to explain some of the code snippets that are not self explanitory
Added icons for the types for every pokemon by pulling their id and fetchign an icon from a github repo for pokemon
Removed the filter for generation, now pokemon can only be sorted by type and game.
Pokemoncards
About page + functionality to change pages
Implemented Tanstack Query for fetching from PokeAPI for easier error handling and request control
Feature/header footer
Session storage
Added A slot for a pokemon team selected randomly from filtered pokemon with favourite functionality,
Combines dev's multi-page site (About/Footer/404 routing via react-router-dom) with the TanStack Query and team-generator work on this branch. Resolved conflicts: - main.tsx: nest RouterProvider inside QueryClientProvider. - Dropped two stray npm package-lock.json files from dev (project uses pnpm) and regenerated pnpm-lock.yaml against the merged package.json. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Team generation
Updated README.md to the first version of a drafted documentation.
Added field to input names for pokemon to let users easily navigate to a spesific resource.
About navigation
feat: Add name filter to search for specific pokemon
Added Vitest tests aswell as updating the README with info on how to run tests and the program.
Avoided blockign the pictures of the pokemon by adding padding to the icons
Carddesign
This was
linked to
issues
Sep 16, 2026
Closed
halvortf
approved these changes
Sep 17, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like everything is "written again", but seems fine when I test the website
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.