Skip to content

Conversation

joelte
Copy link
Member

@joelte joelte commented Oct 10, 2026 •

Started fetching data from the server and made a details page linked to each game.

closes #20 #15

Added the merge for filter functionality on top of this one.
c579f36

joelte added 2 commits October 10, 2026 19:47
A simple details page for games for now with only one example that can be accessed by clicking the games in the list on the frontpage.
Made frontend fetch data from the backend to fill in the grid and details page (only fetching the necessary games at a time)
@joelte joelte added the enhancement New feature or request label Oct 10, 2026
@joelte joelte requested a review from a team as a code owner October 10, 2026 18:09
joelte and others added 3 commits October 10, 2026 20:46
Added filter functionality to search sort and filter games on the mainpage in accordance with the described functionality in README.
Ensured the filters are usabel and responisve for smaller screen sizes.
@joelte joelte requested a review from ayseza October 10, 2026 19:03
Copy link
Member

@ayseza ayseza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to use react-bootstrap so we don't have to deal with this much css. Please replace html tags with their corresponding react-bootstrap components where applicable and refer to classNames instead of styles where applicable.
For example:
<button> will be <Button> then you do not need a :disabled class.
image
The above results in that we do not need any of the following:
Screenshot 2026-10-11 102328

This was linked to issues Oct 11, 2026
Refactored some basic tsx components to be REACT bootstap components instead for easier styling
@joelte joelte requested a review from ayseza October 11, 2026 17:34
@joelte
Copy link
Member Author

joelte commented Oct 11, 2026

We decided to use react-bootstrap so we don't have to deal with this much css. Please replace html tags with their corresponding react-bootstrap components where applicable and refer to classNames instead of styles where applicable. For example: <button> will be <Button> then you do not need a :disabled class. image The above results in that we do not need any of the following: Screenshot 2026-10-11 102328

I have changed the relevant components. It does not decrease the size of the css fields too much as we still need them to maintain readability for smaller screensizes, but i have shortened them somewhat.

Copy link
Member

@ayseza ayseza left a comment •

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Starting to look a lot cleaner 😊

For maintaining readability in smaller sizes we can still use bootstrap classes.
For example adding -sm-, -md-, -lg-, etc. in classNames to define which class applies to which screen size.

@ayseza ayseza merged commit 904f1f2 into dev Oct 11, 2026
@ayseza ayseza deleted the game-detail branch October 11, 2026 18:07
Sign in to join this conversation on GitHub.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start game detail page Replace static data
2 participants