-
Notifications
You must be signed in to change notification settings - Fork 0
Game detail #21
Game detail #21
Conversation
A simple details page for games for now with only one example that can be accessed by clicking the games in the list on the frontpage.
Made frontend fetch data from the backend to fill in the grid and details page (only fetching the necessary games at a time)
Added filter functionality to search sort and filter games on the mainpage in accordance with the described functionality in README.
Ensured the filters are usabel and responisve for smaller screen sizes.
Filter functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to use react-bootstrap so we don't have to deal with this much css. Please replace html tags with their corresponding react-bootstrap components where applicable and refer to classNames instead of styles where applicable.
For example:
<button> will be <Button> then you do not need a :disabled class.
The above results in that we do not need any of the following:
Refactored some basic tsx components to be REACT bootstap components instead for easier styling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Starting to look a lot cleaner 😊
For maintaining readability in smaller sizes we can still use bootstrap classes.
For example adding -sm-, -md-, -lg-, etc. in classNames to define which class applies to which screen size.
Started fetching data from the server and made a details page linked to each game.
closes #20 #15
Added the merge for filter functionality on top of this one.
c579f36