-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add book grid components displaying book cards #7
Conversation
|
Changed the base branch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good as well! Left a small comment on usage of a CSS class.
Co-authored-by: Martin Alexander Kaminski <martakam@stud.ntnu.no>
Co-authored-by: Martin Alexander Kaminski <martakam@stud.ntnu.no>
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other PR does not introduce any breaking changes to this one. Approving again.
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the PR needs to completely up to date with the base branch in order to merge. Interesting.
Adds a responsive grid of book cards, using mock data for now.
Changes include:
.favoriteButtoninBookCard.tsxis currently not doing anything, and is just a placeholder for later developmentBookGrid is currently rendered directly in
App.tsx's main content area. This may change if a different page structure makes more sense later, or if additional components need to be built around BookGrid.Note: This is my first time working with React - so don't hesitate to give feedback.
Closes #5