feat: add ESLint to the backend #111
Merged
+2,008
−1,382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer have a "start" command, so "prestart" makes no sense
This enables the most strict rulesets. It also adjusts the same rules as in frontend
|
Looks good! Nice to have the same strict linting in the backend. This branch is now in conflict with main, I'll fix them, and make a helper function for the work you had to do in this commit to satisfy ESlint: 2ff0b8e |
|
4 tests are failing. 3 that are being fixed in #107 , and one that I'll create an issue for. It's in the FavoriteButton.test.tsx test. Sometimes it works, and sometimes it fails.. weird. Approving this PR |
johahor
approved these changes
Nov 10, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds linting to the backend using ESLint, in a very similar fashion as the frontend.
The most scrict rulesets have been applied, because we strive to write code of high quality (hopefully).
typescript-eslintdoes not support TypeScript v7 yet, so the backend has been downgraded to v6.All issues highlighted by ESLint have been fixed.
Closes #109