Skip to content

Conversation

martakam
Copy link
Member

We can finally add reviews to books, along with our comments.
These are shown on the selectedBook page (/book/[id]) and our profile too.

The favorites on our profile only show three books at once now, so we can see our reviews faster.

Closes #118

@martakam martakam added the enhancement New feature or request label Nov 10, 2026
@martakam martakam added this to the Deliverable 4 milestone Nov 10, 2026
@martakam martakam self-assigned this Nov 10, 2026
@martakam martakam requested a review from a team as a code owner November 10, 2026 20:45
hestro
hestro previously approved these changes Nov 12, 2026
Copy link
Member

@hestro hestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good feature to have!
Using the review functionality works well!

One thing I noticed is that since we now only show three of our favorite books at once on the profile page, the next/previous buttons on the favorites’ selectedBook pages are almost not usable. You can only browse between three books before you have to go back to the profile page, go to the next page, and then you again have three books to browse between on the selectedBook page.

I really like the profile layout now with only three books, so I don’t think we should change that.
But we might want to solve the issue of not being able to browse across the pagination. This behavior isn’t only on the profile page, but also on the books page, so it should definitely be a separate issue.

But the functionality this PR adds is very good! Approved!

@martakam
Copy link
Member Author

Need to merge main again since another PR was merged at the same time lol

@martakam
Copy link
Member Author

Would appreciate an additional check just in case something went wrong when resolving merge conflicts

Copy link
Member

@hestro hestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything is still working well

Sign in to join this conversation on GitHub.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add book reviews
2 participants