-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add search by author along with book titles #127
Open
martakam
wants to merge
22
commits into
main
Choose a base branch
from
feat/author-search
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7,318
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also refactors the orderBy logic in searchBooks, since that started to become some delicious spaghetti
This adds a publish_year SQL column which we will fill out with values once. The frontend no longer needs to extract the publish year, since the backend does it
This sorts for books with most ratings first instead of sorting by id. This is done with sorting by most ratings first, and fuzzy matching is still used when no books match a query
hestro
previously approved these changes
Nov 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Searching for authors worked as expected. Great!
The merge-base changed after approval.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with searching for book titles using the main search bar, users may now also search for authors.
This PR builds upon #117, so it should be merged after that one.
Closes #99