feat: add sort option to search bar #57
Open
+1,025
−283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's enough that a book is in at least one book genre
We had a lot of books with their book format set to an empty string. We prefer the native SQL NULL type instead, so filtering works correctly
Co-authored-by: Johannes Horn <johahor@stud.ntnu.no>
…T37-Project-2 into feat/sort-by-rating
|
While the git history may look weird, everything is fine. This branch had a merge conflict with main because of the same issue as in #51, and this PR builds on top of that one. For details, please read comment the following comment: #51 (comment) In order to re-use the same fix as was applied in #51, I rebased this branch against #51. I'll review as normal now |
martakam
previously approved these changes
Oct 24, 2026
Co-authored-by: Martin Alexander Kaminski <martakam@stud.ntnu.no>
martakam
previously approved these changes
Oct 25, 2026
johahor
dismissed
martakam’s stale review
The merge-base changed after approval.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic sort functionality to the searchBar, so users can now sort by Rating.
Suggested follow-ups related to "Rating" would be:
Show rating in BookCard and selectedBook.
Add possibility for Logged in users to give a book a rating (and possible show all the books they have rated in another page as well, but this is not high priority)
This PR builds on #51 and should be merged after that.
Closes #37