Enforce layer separation: route GUI database calls through logic layer #55

francinv · 2026-04-06T19:53:16Z

Screen helpers bypass the game logic layer and call DatabaseManager directly.

Files that violate layering:

LobbyValidator.java:5
LobbyFlowController.java:5
SetupFlowController.java:5
GameNetworkHandler.java:8

What to do:

Move database interactions into states/ or new service classes in model/
Screen helpers should call logic-layer methods instead of DatabaseManager.getInstance() directly
After fix: grep -r "DatabaseManager" screens/ should return zero results

Ref: Architecture doc claims strict one-way GUI → Logic → Database layering.

The text was updated successfully, but these errors were encountered:

Route all database calls through state classes instead of calling DatabaseManager directly from screen helpers. - LobbyState: add validateLobby, listenForOpponentReady, startGame, listenForGameStart wrapper methods - SetupState: add confirmSetup, unconfirmSetup, listenForBothSetupReady, getOpponentBoard, getFirebaseApi wrapper methods - LobbyValidator: route through LobbyState instead of DatabaseManager - LobbyFlowController: route through LobbyState - SetupFlowController: route through SetupState - GameNetworkHandler: accept FirebaseAPI via constructor injection - Thread LobbyState through MainMenuScreen→MainMenuUI→JoinGamePanel - Thread FirebaseAPI through SetupScreen→GameScreen→GameNetworkHandler Result: zero DatabaseManager references in screens/ package

francinv assigned francinv and unassigned francinv Apr 6, 2026

francinv mentioned this issue Apr 6, 2026

refactor: enforce GUI→Logic→Database layer separation #61

Merged

Enforce layer separation: route GUI database calls through logic layer #55

Enforce layer separation: route GUI database calls through logic layer #55

Comments

francinv commented Apr 6, 2026