fix(#40): minor coderabbit improvements

src/AcceptedFiltering/threePanels.js

@@ -47,12 +47,14 @@ function insertSection({ headerId, headerText, listId }) {
   accordionRefresh()
 
   header.addEventListener('click', () => {
-    if ($(menu).accordion && $(menu).data('uiAccordion')) return
-    if (window.jQuery) {
-      const $p = window.jQuery(panel)
+    const $ = window.jQuery || window.$
+    if ($ && $.fn?.accordion && $(menu).data('uiAccordion')) return
+    if ($) {
+      const $p = $(panel)
       $p.is(':visible') ? $p.slideUp(350) : $p.slideDown(350)
       return
     }
+    panel.style.display = panel.style.display === 'none' ? '' : 'none'
   })
 }
 
@@ -404,7 +406,7 @@ async function switchMode(mode, hook, hooksBag = {}) {
  * @param {()=>'elevation'|'accepted'} activeGetter
  * @returns {MutationObserver}
  */
-function attachSelfHealing(activeGetter) {
+function attachSelfHealing(activeGetter, hooks) {
   const root = byId('potree_menu') || document.body
   const obs = new MutationObserver(() => {
     const mode = activeGetter()

src/AnnotationControl/annotationPanel.js

@@ -56,12 +56,14 @@ export function initAnnotationsPanel(viewer) {
 
       // Toggle collapse
       header.addEventListener('click', () => {
-        if ($(menu).accordion && $(menu).data('uiAccordion')) return
-        if (window.jQuery) {
-          const $p = window.jQuery(panel)
+        const $ = window.jQuery || window.$
+        if ($ && $.fn?.accordion && $(menu).data('uiAccordion')) return
+        if ($) {
+          const $p = $(panel)
           $p.is(':visible') ? $p.slideUp(350) : $p.slideDown(350)
           return
         }
+        panel.style.display = panel.style.display === 'none' ? '' : 'none'
       })
       targetContainer = panel.querySelector('#annotations_list')
     }

src/potreeViewer.js

@@ -35,6 +35,8 @@ export async function createPotreeViewer(
   viewer.loadSettingsFromURL()
   viewer.setDescription('Molloy Explorer')
 
+  const pointclouds = []
+
   viewer.loadGUI(() => {
     viewer.setLanguage('en')
     $('#menu_appearance').next().show()
@@ -108,7 +110,6 @@ export async function createPotreeViewer(
     initAnnotationsPanel(viewer)
   })
 
-  const pointclouds = []
   for (const url of pointcloudUrls) {
     const e = await Potree.loadPointCloud(url)
     const pc = e.pointcloud
@@ -128,14 +129,6 @@ export async function createPotreeViewer(
     pointclouds.push(pc)
   }
 
-  // Change name of default background from 'None' to 'Globe"'
-  $('#background_options_none')
-    .text('Globe')
-    .attr('id', 'background_options_globe')
-    .val('globe')
-
-  viewer.setBackground('globe')
-
   // Initialize camera position and target point (manually chosen)
   viewer.scene.view.setView(
     [3961574.044, 1494736.334, 8348318.575], // Initial camera position
@@ -320,10 +313,11 @@ function overrideGradientSchemeClick(pointclouds, setLastElevationGradient) {
   const gradientContainer = document.getElementById(
     'elevation_gradient_scheme_selection'
   )
+  if (!gradientContainer) return
   const spans = gradientContainer.querySelectorAll('span')
   if (spans.length) {
     spans.forEach((span, idx) => {
-      span.onclick = () => {
+      span.addEventListener('click', () => {
         const gradientNames = Object.keys(Potree.Gradients)
         const gradientName = gradientNames[idx]
         if (gradientName) {
@@ -332,7 +326,7 @@ function overrideGradientSchemeClick(pointclouds, setLastElevationGradient) {
           })
           setLastElevationGradient(gradientName)
         }
-      }
+      })
     })
   }
 }