Skip to content

#9 Coastline overlay #22

Merged
merged 17 commits into from
Oct 6, 2025
Merged

#9 Coastline overlay #22

merged 17 commits into from
Oct 6, 2025

Conversation

adriahso
Copy link
Member

@adriahso adriahso commented Oct 4, 2025

Description of change

Added a Cesium globe in order to see where the point cloud is located. This includes:

  • Limiting how far out you can zoom
  • Hiding the globe whenever the camera moves inside the globe or if the pivot would be behind the curvature of the Earth
  • General restructuring of the codebase

Note: I also had to hide the globe when the camera is directly above the point, as this caused syncing issues between the point cloud and the globe.

Testing steps

  • The coordinate system needs to be changed from EPSG:25832 to EPSG:4978. The script I used for the conversion is at the bottom of MolloyExplorer/Technical/PotreeSetup under "EPSG:25832 => EPSG:4978 las conversion" in the Google Drive.
  • Try to play around with the camera, gradients and other tools to see that it works well.

Closes #9

@adriahso adriahso self-assigned this Oct 4, 2025
@adriahso adriahso linked an issue Oct 4, 2025 that may be closed by this pull request
@kleinc kleinc self-requested a review October 5, 2025 13:10
Copy link
Member

@kleinc kleinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it looks really good! I made som few comments. Just one thing I noticed: I was not able to render the compass when I tried to add it. It doesn't give any errors either in the console, so not sure why it's not visible.

@adriahso
Copy link
Member Author

adriahso commented Oct 5, 2025

Nice, it looks really good! I made som few comments. Just one thing I noticed: I was not able to render the compass when I tried to add it. It doesn't give any errors either in the console, so not sure why it's not visible.

Hmm, the compass shows up for me. Are you sure you just clicked the compass button and didn't try to drag it out into the viewer? Feel like I have made that mistake earlier.

@adriahso adriahso requested a review from kleinc October 5, 2025 17:19
@kleinc
Copy link
Member

kleinc commented Oct 5, 2025

The compass shows up now, I suppose it was just lagging earlier.

Copy link
Member

@kleinc kleinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The new changes look good.

Copy link
Member

@franmagn franmagn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good and explainatory!

@adriahso adriahso merged commit c32efa6 into dev Oct 6, 2025
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coastline overlay
3 participants