Skip to content

feat: 🩹 Prevent multiple clicks on cloud icon for sm… #33

Merged
merged 3 commits into from
Oct 10, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/ElevationControl/elevationControl.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ window.createElevationPanel = function createElevationPanel(viewer) {
}
}

//Select the fist pointcloud in the sidebar so that the Elevation section is built
/**
* Select the fist pointcloud in the sidebar so that the Elevation section is built
*/
function autoSelectFirstPointCloud() {
const cloudIcon = document.querySelector(
'#scene_objects i.jstree-themeicon-custom'
Expand All @@ -49,6 +51,25 @@ function autoSelectFirstPointCloud() {
return false
}

/**
* Disable any further clicks of the pointcloud icon in the sidebar
*/
function disableFirstPointCloudNode() {
// find the <li> that holds the first cloud icon
const icon = document.querySelector(
'#scene_objects i.jstree-themeicon-custom'
)
const li = icon ? icon.closest('li') : null
if (!li) return
//visually/DOM disable anchor clicks
const a = li.querySelector('a')
if (a) {
a.style.pointerEvents = 'none'
a.style.opacity = 0.5
a.classList.remove('jstree-clicked')
}
}

//(re)connect the elevation labels to the slider after the container is moved (was not handled by default)
function rebindElevationLabel() {
const slider = window.jQuery ? window.jQuery('#sldHeightRange') : null
Expand Down Expand Up @@ -109,5 +130,8 @@ export function initElevationControls(viewer) {
observer.observe(menu, { childList: true, subtree: true })

//Trigger Potree to build Materials UI by selecting the first point cloud (if nothing selected yet)
autoSelectFirstPointCloud()
if (autoSelectFirstPointCloud()) {
//Prevent multiple clicks on the cloud icon
disableFirstPointCloudNode()
}
}