refactor(#25): ♻️ Changed from canvas to text element, lat/lon… #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to show target point, don't update target point if right-clicking Did a complete refactor of the coordinate showing logic, to use text element. Also made sure that the lat/lon coordinates are those of the target point. The coordinates won't change when right-clicking. Did some changes in styling as well.
franmagn
requested changes
Oct 13, 2025
|
Fixed it now 🦖 |
|
Generally looks good to me. Though had some issues with copying the coordinates on screen |
|
Fixed now! |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing issue
Closes #25
Description
Did a complete refactor of the coordinate-showing logic, to use text element instead of canvas element. Also made sure that the lat/lon coordinates are those of the target point. The coordinates will no longer change when right-clicking, but only update when double clicking on a point. Did some changes in styling as well.
Testing steps
Screenshots